Rust: Add more CFG tests #17626
Merged
Rust: Add more CFG tests #17626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
approved these changes
Sep 30, 2024
| @@ -64,18 +64,18 @@ predicate trivialPat(Pat p) { p instanceof WildcardPat or p instanceof IdentPat | |||
| class AsmExprTree extends LeafTree instanceof AsmExpr { } | |||
|
|
|||
| class AwaitExprTree extends StandardPostOrderTree instanceof AwaitExpr { | |||
| override ControlFlowTree getChildNode(int i) { i = 0 and result = super.getExpr() } | |||
| override AstNode getChildNode(int i) { i = 0 and result = super.getExpr() } | |||
There was a problem hiding this comment.
Why these changes? I don't think they're bad, just wondering why they were made in a commit with title Rust: Add more CFG tests.
There was a problem hiding this comment.
Without this change we do not get the dead-end inconsistency for the while loop test, because WhileExpr is not (yet) a ControlFlowTree.
|
@hvitved Why did you merge this into |
D'oh, sorry. I merged on mobile; didn't see the CI failure. Fix here: #17627. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a bunch of test cases for functions with incorrect CFGs.