Skip to content

Java/C++/C#: Add field flow support for stores in nested fields. #1766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2019

Conversation

aschackmull
Copy link
Contributor

This is essentially a one-line change to the field flow implementation, which enables tracking of stores into nested fields. In order for this to work, all of the associated nodes need to have corresponding PostUpdateNodes, so a few needed to be added for Java. The test case highlights the new possibilities for flow tracking.

Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jbj jbj merged commit 432b0a4 into github:master Aug 20, 2019
@aschackmull aschackmull deleted the java/nested-storestep branch August 20, 2019 08:06
jbj added a commit to jbj/ql that referenced this pull request Aug 20, 2019
This is the C/C++ side of PR github#1766.
@yh-semmle
Copy link
Contributor

For reference, the result changes on JDK 8 were:

=== Changes per project (new / fixed) ===

jdk8-java-2                                                                14 / 7


=== Changes per query (new / fixed) ===

ArithmeticWithExtremeValues.ql                                             14 / 2
ConditionalBypass.ql                                                        0 / 4
ZipSlip.ql                                                                  0 / 1

@aschackmull
Copy link
Contributor Author

I just sanity-checked the missing ZipSlip result - it's a FP and can be made to reappear by setting e.g. override int fieldFlowBranchLimit() { result = 10 }, so I'd say those result changes look fine.

jbj added a commit to jbj/ql that referenced this pull request Aug 23, 2019
This is the C/C++ side of PR github#1766.
@hvitved hvitved mentioned this pull request Aug 23, 2019
geoffw0 pushed a commit to geoffw0/ql that referenced this pull request Sep 2, 2019
This is the C/C++ side of PR github#1766.
jbj added a commit to jbj/ql that referenced this pull request Sep 3, 2019
This is the C/C++ side of PR github#1766.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants