KE2: Extract local variable declarations #17707
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igfoo
reviewed
Oct 9, 2024
| * same variable may be referred to from distant places in the IR, so we need a way to find out | ||
| * which label is used for a given local variable. This information is stored in this mapping. | ||
| */ | ||
| private val variableLabelMapping: MutableMap<KtProperty, Label<out DbLocalvar>> = |
There was a problem hiding this comment.
Could you add something like // TODO: This should be in a subclass so that DiagnosticTrapWriter doesn't include it, as it is not threadsafe please?
| return variableLabelMapping.get(v) | ||
| } | ||
| */ | ||
| fun getExistingVariableLabelFor(v: KtProperty): Label<out DbLocalvar>? { |
There was a problem hiding this comment.
I think this can remain commented out with OLD: KE1. I hope we'll be able to remove it once we've reimplemented comment extraction.
| parent: Label<out DbExprparent>, | ||
| idx: Int, | ||
| enclosingStmt: Label<out DbStmt>, | ||
| extractInitializer: Boolean = true |
There was a problem hiding this comment.
Are we definitely going to need this in KE2? Should we leave it commented out, or at least add a TODO, if we don't know?
igfoo
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.