Skip to content

Go: extractor/objecttypes consistency generics #17709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

owen-mc
Copy link
Contributor

@owen-mc owen-mc commented Oct 9, 2024

No description provided.

@github-actions github-actions bot added the Go label Oct 9, 2024
Copy link
Contributor

@smowton smowton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible

@smowton
Copy link
Contributor

smowton commented Oct 9, 2024

Recommend DCA including some projects known to use generics to check for alert differences

@owen-mc
Copy link
Contributor Author

owen-mc commented Oct 9, 2024

Yes, we definitely need to make sure that the checks won't just cause us to stop in the middle of extraction. I did MRVA on go/ql/test/library-tests/semmle/go/Function/GenericFunctionInstantiationExpr.ql to get a list of repos for DCA. Unfortunately DCA is down at the moment.

@owen-mc owen-mc force-pushed the go/extractor/objecttypes-consistency-generics branch from f7c2ba9 to 513efe2 Compare October 10, 2024 13:00
@owen-mc owen-mc marked this pull request as ready for review October 10, 2024 16:29
@owen-mc owen-mc requested a review from a team as a code owner October 10, 2024 16:29
@owen-mc owen-mc merged commit d0f73ac into github:main Oct 10, 2024
13 checks passed
@owen-mc owen-mc deleted the go/extractor/objecttypes-consistency-generics branch October 10, 2024 16:30
@owen-mc
Copy link
Contributor Author

owen-mc commented Oct 10, 2024

DCA looked fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants