Skip to content

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Oct 9, 2024

More test cases for unused variables. Confirms that the issue producing spurious results for None matches is due to use of unqualified enum values that are being misrecognized as variables.

@geoffw0 geoffw0 added the Rust Pull requests that update Rust code label Oct 9, 2024
Copy link
Contributor

@hvitved hvitved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor things, otherwise LGTM

@geoffw0
Copy link
Contributor Author

geoffw0 commented Oct 9, 2024

Corrected minor mistakes and added one more test case.

@geoffw0 geoffw0 merged commit ed39c46 into github:main Oct 9, 2024
12 checks passed
@geoffw0 geoffw0 deleted the unusedvar3 branch October 29, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants