Rust: add MacroPat to isExhaustiveMatch #17746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
force-pushed
the
aibaars/macro-pat-irrefutable
branch
from
8a3c8fc to
493a68a
Compare
aibaars
changed the title
paldepind
reviewed
Oct 14, 2024
| @@ -149,6 +152,8 @@ private predicate isExhaustiveMatch(Pat pat) { | |||
| or | |||
| pat = parent.(IdentPat).getPat() | |||
| or | |||
| pat = parent.(MacroPat).getMacroCall().getExpanded() | |||
There was a problem hiding this comment.
Why is this necessary and L143 not enough?
If I understand correctly the cases here are about the exhaustiveness property flowing from patterns to their child constituents. This added line doesn't seem to really fit that pattern?
There was a problem hiding this comment.
Line 143 is for cases where a macro expands to a pattern that is known to be exhaustive (eg a wildcard) in that case the macro invocation is an exhaustive pattern.
Line 155 is for the case where a macro invocation appears in a position that should be exhaustive, such as the last arm in a match. In this case whatever the macro expands to is considered to be exhaustive as well.
Co-authored-by: Simon Friis Vindum <simonfv@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hvitved