Rust: Rust: add jump to definition for format arguments #17805
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| import codeql.rust.elements.GenericParam | ||
| import codeql.rust.elements.GenericParamList | ||
| import codeql.rust.elements.IdentPat | ||
| import codeql.rust.elements.IfExpr |
Check warning
Code scanning / CodeQL
Redundant import Warning
|
|
||
| private import internal.FormatArgumentImpl | ||
| import codeql.rust.elements.Format | ||
| import codeql.rust.elements.Locatable |
Check warning
Code scanning / CodeQL
Redundant import Warning
aibaars
force-pushed
the
aibaars/local-defs
branch
from
8653e35 to
a755175
Compare
aibaars
force-pushed
the
aibaars/rust-format-templates
branch
2 times, most recently
from
4cfbd20 to
24abe34
Compare
aibaars
force-pushed
the
aibaars/local-defs
branch
from
a755175 to
54589af
Compare
aibaars
force-pushed
the
aibaars/rust-format-templates
branch
from
24abe34 to
a7628e7
Compare
aibaars
force-pushed
the
aibaars/local-defs
branch
2 times, most recently
from
17d4746 to
35b4aa0
Compare
aibaars
force-pushed
the
aibaars/local-defs
branch
from
35b4aa0 to
f092594
Compare
| /** | ||
| * Gets an element, of kind `kind`, that element `use` uses, if any. | ||
| */ | ||
| cached |
There was a problem hiding this comment.
You should probably also cache TDef, and make sure to cache them together, e.g.
private cached module Cached {
cached newtype TDef ...
cached Definition definitionOf(Use use, string kind) ...
}
predicate definitionOf = Cached::definitionOf/2;| private import codeql.Locations | ||
|
|
||
| /** An element with an associated definition. */ | ||
| abstract class Use extends Locatable { |
There was a problem hiding this comment.
It probably makes sense to restrict this to uses that are not the result of a macro expansion?
There was a problem hiding this comment.
Not sure I understand. This PR adds jump to definition for format arguments, which are all uses that are the result of macro expansion.
Perhaps we should restrict the definitions though. That should get rid of all the left_val and right_val references in the expansion of assert! macros.
| */ | ||
|
|
||
| private import codeql.rust.elements.Variable | ||
| private import codeql.rust.elements.Locatable |
Check warning
Code scanning / CodeQL
Redundant import Warning
|
|
||
| private import codeql.rust.elements.Variable | ||
| private import codeql.rust.elements.Locatable | ||
| private import codeql.rust.elements.FormatArgsExpr |
Check warning
Code scanning / CodeQL
Redundant import Warning
| private import codeql.rust.elements.Variable | ||
| private import codeql.rust.elements.Locatable | ||
| private import codeql.rust.elements.FormatArgsExpr | ||
| private import codeql.rust.elements.FormatArgsArg |
Check warning
Code scanning / CodeQL
Redundant import Warning
@hvitved FYI