Go: Fix makefile to use bash to look up bazel path. #17821
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Windows, make's path resolution algorithm is incorrect. It picks up a bazel.exe in PATH that's _after_ a bazel binary. In particular, on actions, the non-exe binary is a bazelisk instance, whereas bazel.exe is a bazel (at the current time 7.3.2) installation. This means we pick up the wrong bazel version, and if the differences between the bazel we want and that we actually get are too big, the build fails.
redsun82
reviewed
Oct 22, 2024
| @@ -1,3 +1,5 @@ | |||
| BAZEL := $(shell bash -c "which bazel") | |||
There was a problem hiding this comment.
probably worth a small comment pointing out the windows make binary resolution bug, or someone in the future might revert this thinking "why not use bazel directly?"
There was a problem hiding this comment.
argh I thought I did that, I wanted to do that, and apparently all I did was writing the commit explanation. I'm clearly too tired.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, make's path resolution algorithm is incorrect. It picks up a bazel.exe in PATH that's after a bazel binary. In particular, on actions, the non-exe binary is a bazelisk instance, whereas bazel.exe is a bazel (at the current time 7.3.2) installation.
This means we pick up the wrong bazel version, and if the differences between the bazel we want and that we actually get are too big, the build fails.
Thanks to @smowton and @redsun82 for debugging help!