Rust: add extended_canonical_path and crate_origin to Item
#17825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
force-pushed
the
redsun82/rust-canonical-path
branch
2 times, most recently
from
8144f90 to
e7c9003
Compare
redsun82
force-pushed
the
redsun82/rust-canonical-path
branch
from
785aa4e to
719b5e1
Compare
redsun82
changed the title
canonical_path and crate_origin to Itemextended_canonical_path and crate_origin to Item
aibaars
reviewed
Oct 30, 2024
| @@ -20,62 +23,30 @@ use ra_ap_syntax::{ | |||
| #[macro_export] | |||
| macro_rules! emit_detached { | |||
| (MacroCall, $self:ident, $node:ident, $label:ident) => { | |||
| $self.extract_macro_call_expanded(&$node, $label.into()); | |||
| $self.extract_macro_call_expanded(&$node, $label); | |||
There was a problem hiding this comment.
Out of curiosity, if the into() here wasn't needed, why is it needed for all the other lines below?
There was a problem hiding this comment.
That function is only called on macros and macro labels. The other calls below accept an Item label, which is a super-type of the specific label being produced in the extractor and therefore requires the conversion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an internal
extended_canonical_pathandcrate_originproperty to allItems.The former is the same as canonical paths, with the extension being that items defined in blocks get a
{<block_id>}prefix. As these items can be referenced to within the scope in which they are visible, we will need such extension.Building upon this, we can extract path resolution from rust-analyzer using this same format (in an upcoming PR).
One thing to notice is that those paths identify an entity only within a given crate. To allow for cross-crate references I've added
crate_origin, but that is just an experiment. It is something that rust-analyzer itself has, but we need to play around with to see if it's really useful. It might be we will need to insert crate root file paths and maybe CFG values in it for it to be meaningful for cross-crate dependencies, but this can be done in upcoming PRs.