Skip to content

Remove macos-12 and its variants, deprecated #17838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2024
Merged

Remove macos-12 and its variants, deprecated #17838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a467923
Remove macos-12 and its variants, deprecated
oscarsj Oct 24, 2024
c2a644b
Update macOS version in build workflow
oscarsj Oct 25, 2024
8f7ed21
Update macOS version in workflow file
oscarsj Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build-ripunzip.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-20.04, macos-12, windows-2019]
os: [ubuntu-20.04, macos-13, windows-2019]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v4
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/swift.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ jobs:
# without waiting for the macOS build
build-and-test-macos:
if: github.repository_owner == 'github'
runs-on: macos-12-xl
runs-on: macos-13-xlarge
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This WF I'm not sure whether it should be on 13 or 14, but in the bigger sense it doesn't really matter. Let's keep this as-is.

steps:
- uses: actions/checkout@v4
- uses: ./swift/actions/build-and-test
Expand All @@ -64,7 +64,7 @@ jobs:
qltests-macos:
if: ${{ github.repository_owner == 'github' && github.event_name == 'pull_request' }}
needs: build-and-test-macos
runs-on: macos-12-xl
runs-on: macos-13-xlarge
steps:
- uses: actions/checkout@v4
- uses: ./swift/actions/run-ql-tests
Expand Down
4 changes: 1 addition & 3 deletions docs/codeql/reusables/supported-platforms.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,7 @@
Windows,"Windows 10 / Windows Server 2019

Windows 11 / Windows Server 2022","x86-64"
macOS,"macOS 12 Monterey

macOS 13 Ventura
macOS,"macOS 13 Ventura

macOS 14 Sonoma","x86-64, arm64 (Apple Silicon)

Expand Down
Loading