Skip to content

Rust: Cache Locatable.getLocation and Location #17844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2024
Merged

Rust: Cache Locatable.getLocation and Location #17844

merged 1 commit into from
Oct 28, 2024

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 25, 2024 •
edited
Loading

Follows up on #17791. Recovers most of the performance we lost.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Oct 25, 2024
@hvitved hvitved force-pushed the rust/location-impl branch from a8a9f22 to 91ad43f Compare October 28, 2024 08:28
@hvitved hvitved force-pushed the rust/location-impl branch from 91ad43f to 711dfc3 Compare October 28, 2024 12:33
@hvitved hvitved marked this pull request as ready for review October 28, 2024 12:52
@hvitved hvitved requested a review from aibaars October 28, 2024 13:22
aibaars
aibaars approved these changes Oct 28, 2024
View reviewed changes
Copy link
Contributor

@aibaars aibaars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me.

@hvitved hvitved merged commit cfa1ed3 into github:main Oct 28, 2024
14 checks passed
@hvitved hvitved deleted the rust/location-impl branch October 28, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aibaars aibaars aibaars approved these changes

Assignees
No one assigned
Labels
Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @aibaars