Rust: Implement enclosing callable #17921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
paldepind
force-pushed
the
rust-df-enclosing-callable
branch
from
af5561c to
75e055c
Compare
paldepind
force-pushed
the
rust-df-enclosing-callable
branch
from
75e055c to
dadc605
Compare
hvitved
requested changes
Nov 7, 2024
| /** Gets the underlying source code call, if any. */ | ||
| abstract CallCfgNode asCall(); | ||
|
|
||
| abstract string toString(); |
There was a problem hiding this comment.
Add QL doc: Gets a textual representation of this call.
| RustDataFlow::ReturnKind getKind() { none() } | ||
| /** A data flow node that represents a value returned by a callable. */ | ||
| final class ReturnNode extends ExprNode { | ||
| ReturnNode() { this.getCfgNode().getASuccessor() instanceof ExitCfgNode } |
There was a problem hiding this comment.
I think this should just be ReturnExprs.
There was a problem hiding this comment.
Ok, so we don't want to include implicit returns like fn foo() { 12 }?
There was a problem hiding this comment.
Right, we need to include that as well.
There was a problem hiding this comment.
I've reinstated the old implementation again :). If we want to include implicit returns then I think just looking at edges into the exit node handles all cases.
returngoes directly to the exit node- In the absence of explicit returns, the
BlockExpris last both in a function and in a closure and it lets the final expression flow through if there is no;at the end. - For a lambda without braces
|a| a + 1the single expression has an edge to the exit node.
rust/ql/test/extractor-tests/generated/Function/CONSISTENCY/DataFlowConsistency.expected
Show resolved
Hide resolved
hvitved
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fills out some more of the data flow implementation, including an implementation of
nodeGetEnclosingCallable. This fixes a good deal of theuniqueEnclosingCallableinconsistencies. There is only 7 left post this PR.