KE2: Extract compareTo calls for binary comparisons
#17939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tamasvajk
force-pushed
the
ke2-binary-op-compareTo
branch
from
91b05f0 to
c55bad5
Compare
igfoo
approved these changes
Nov 12, 2024
| KtTokens.LTEQ -> extractRawBinaryExpression(builtinTypes.boolean, exprParent, tw::writeExprs_leexpr) | ||
| KtTokens.GTEQ -> extractRawBinaryExpression(builtinTypes.boolean, exprParent, tw::writeExprs_geexpr) | ||
| else -> TODO("error") | ||
| } |
There was a problem hiding this comment.
This could also be rewritten along the lines of
val writeExprs_kind = when (op) ...
extractRawBinaryExpression(builtinTypes.boolean, exprParent, writeExprs_kind)
to remove some duplication.
| TODO() | ||
| } | ||
|
|
||
| // Extract lowered equivalent call, such as `a.compareTo(b) < 0` |
There was a problem hiding this comment.
I think a more detailed comment will be helpful in a few months, when we're looking at this having forgotten the context. Perhaps an example of a line of source code, what the AST looks like for it, and an explanation of what target points to, and what we need to fabricate.
tamasvajk
force-pushed
the
ke2-binary-op-compareTo
branch
from
c55bad5 to
70658bc
Compare
|
@igfoo, I rebased this PR and pushed an extra commit to cover your findings. |
igfoo
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.