Swift: More model repairs for Swift 6 #17989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
reviewed
Nov 15, 2024
jketema
approved these changes
Nov 18, 2024
|
@redsun82 probably best if you merge this, to avoid surprises as it targets your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like all the issues with flow through conversions in the Swift 6 PR are modelling issues. In particular, some of the initialisers of
Numericare now initializers ofSignedInteger+UnsignedIntegerinstead (or possibly as well) in Swift 6. There are other changes as well, and as far as I'm aware we don't have a reliable way to tell what they are (unless, perhaps, there is updated documentation I'm unaware of). In any case I have expanded the tests in an attempt to catch all I can, expanded models to cover the regressions I found (in some cases we probably have slightly more flow now), and I fixed a couple of issues that came up in query tests as well.