Skip to content

Rust: only accept options.yml in QL tests #18003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 18, 2024
Merged

Rust: only accept options.yml in QL tests #18003

merged 2 commits into from
Nov 18, 2024

Conversation

redsun82
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Nov 18, 2024
hvitved
hvitved previously approved these changes Nov 18, 2024
View reviewed changes
@redsun82
Copy link
Contributor Author

ah, I guess the test difference shows why one might want to use options instead of options.yml, to avoid YAML extraction to pick up the file. I'm still ok with going with this, and just update the test expectations there.

@redsun82 redsun82 requested a review from hvitved November 18, 2024 11:06
@redsun82 redsun82 merged commit f7ee5f4 into main Nov 18, 2024
13 checks passed
@redsun82 redsun82 deleted the redsun82/rust-qltest branch November 18, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hvitved hvitved hvitved approved these changes

Assignees
No one assigned
Labels
Rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@redsun82 @hvitved