Rust: fix windows flakiness #18167
Merged
Rust: fix windows flakiness #18167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
redsun82
force-pushed
the
redsun82/rust-windows-flaky-test
branch
from
0533415 to
4889032
Compare
redsun82
changed the title
This reverts commit 90fa3ec.
paldepind
approved these changes
Nov 29, 2024
Comment on lines
+201
to
+202
| // There seems to be some flaky inconsistencies around UNC paths on Windows, so if we fail to | ||
| // find the file id for a UNC path like that, we try to canonicalize it using dunce then. |
There was a problem hiding this comment.
Suggested change
| // There seems to be some flaky inconsistencies around UNC paths on Windows, so if we fail to | |
| // find the file id for a UNC path like that, we try to canonicalize it using dunce then. | |
| // There seems to be some flaky inconsistencies around UNC paths on Windows, so if we fail to | |
| // find the file id for a UNC path, we try with a canonicalized (by dunce) path as well. |
There was a problem hiding this comment.
Makes sense! I'll do a follow up though on Monday, I prefer to not have the flakiness in for the nightlies 🙂
redsun82
pushed a commit
that referenced
this pull request
Dec 2, 2024
This is a follow up to #18167, addressing a review comment from @paldepind.
redsun82
pushed a commit
that referenced
this pull request
Dec 2, 2024
This is a follow up to #18167, addressing a review comment from @paldepind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.