Python: Add models for builtins map, filter, zip, and enumerate.
#18301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joefarebrother
changed the title
map, filter, zip, and enumerate.map, filter, zip, and enumerate.
joefarebrother
force-pushed
the
python-model-missing-builtins
branch
2 times, most recently
from
8128500 to
7e83b0f
Compare
joefarebrother
force-pushed
the
python-model-missing-builtins
branch
3 times, most recently
from
0f2f3f5 to
e7649e3
Compare
joefarebrother
force-pushed
the
python-model-missing-builtins
branch
from
e7649e3 to
6a6585e
Compare
joefarebrother
force-pushed
the
python-model-missing-builtins
branch
from
36172dc to
2aea356
Compare
joefarebrother
changed the title
map, filter, zip, and enumerate.map, filter, zip, and enumerate.
There was a problem hiding this comment.
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (1)
- python/ql/lib/semmle/python/frameworks/Stdlib.qll: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
yoff
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
This is a clear improvement from the current situation. I think at some point we want to be able to typetrack through these summaries, given that they are widely used built in functions. Ideally, though, we would first create Pre-API::builtin("map"); a way to fairly reliably identify uses of "map" and others without using the real API graph. Then we could easily write all the simple summaries we want.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These builtins were missing models; this PR adds support for them.