C# 13: Partial properties and indexers. #18533
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelnebel
force-pushed
the
csharp/partialmembers
branch
6 times, most recently
from
ca0f73b to
ec17a0e
Compare
|
DCA looks good. |
There was a problem hiding this comment.
Copilot reviewed 10 out of 25 changed files in this pull request and generated 2 comments.
Files not reviewed (15)
- csharp/ql/test/library-tests/dataflow/fields/FieldFlow.expected: Language not supported
- csharp/ql/test/library-tests/dataflow/indexers/IndexerFlow.expected: Language not supported
- csharp/ql/test/library-tests/dataflow/indexers/IndexerFlow.ql: Language not supported
- csharp/ql/test/library-tests/dispatch/CallGraph.expected: Language not supported
- csharp/ql/test/library-tests/dispatch/GetADynamicTarget.expected: Language not supported
- csharp/ql/test/library-tests/dispatch/viableCallable.expected: Language not supported
- csharp/ql/test/library-tests/partial/MethodIsPartial.expected: Language not supported
- csharp/ql/test/library-tests/partial/Partial1.expected: Language not supported
- csharp/ql/test/library-tests/partial/Partial2.expected: Language not supported
- csharp/ql/test/library-tests/partial/PartialAccessors.expected: Language not supported
- csharp/ql/test/library-tests/partial/PartialAccessors.ql: Language not supported
- csharp/ql/test/library-tests/partial/PartialIndexers.expected: Language not supported
- csharp/extractor/Semmle.Extraction.CSharp/Entities/Indexer.cs: Evaluated as low risk
- csharp/extractor/Semmle.Extraction.CSharp/Entities/Accessor.cs: Evaluated as low risk
- csharp/ql/test/library-tests/dataflow/fields/D.cs: Evaluated as low risk
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
… accessor implementations instead of declarations.
michaelnebel
force-pushed
the
csharp/partialmembers
branch
from
1e9a7bd to
501f985
Compare
hvitved
reviewed
Jan 30, 2025
hvitved
approved these changes
Feb 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we make support for partial property and indexer definitions (as described here).
As opposed to partial methods it is worth noting that partial indexers and properties always both have a declaring declaration and an implementation declaration. Thus we need to disregard the declaration get and set (as they are not callables).