Rust: Hide internal implementation details from DataFlow::Node
#18657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hvitved
force-pushed
the
rust/dataflow-node-api
branch
2 times, most recently
from
f738959 to
8435700
Compare
hvitved
force-pushed
the
rust/dataflow-node-api
branch
from
8435700 to
45fc1da
Compare
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more
geoffw0
reviewed
Feb 3, 2025
| /** | ||
| * Gets this node's underlying SSA definition, if any. | ||
| */ | ||
| Ssa::Definition asDefinition() { none() } |
There was a problem hiding this comment.
This method doesn't seem to have a non-none definition anywhere and is not used. Was it just copied from another language or is there more going on here?
There was a problem hiding this comment.
It was probably just copied.
geoffw0
reviewed
Feb 3, 2025
There was a problem hiding this comment.
Seems reasonable, but I'd like @paldepind to at least see this before it's merged.
paldepind
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.