JS: whitelist quote stripping for js/incomplete-sanitization #1876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ghost
self-requested a review
as a 
|
I assume you have verified that this doesn't lose any interesting results? I would have thought that removing quotes via |
I do not think it is any less wrong than trying to remove other delimiter pairs this way. The pattern is rare though: 0 results for 236 projects (https://lgtm.com/query/5904476558374725002/). |
Braces are less frequently backslash-escaped, no? |
|
But good to hear that it doesn't happen in practice, so sounds fine to whitelist. |
xiemaisi
approved these changes
Sep 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.