JS: Migrate model of URLSearchParams #18768
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
javascript/ql/lib/semmle/javascript/internal/flow_summaries/UrlSearchParams.qll
Fixed
Show fixed
Hide fixed
javascript/ql/lib/semmle/javascript/internal/flow_summaries/UrlSearchParams.qll
Dismissed
Show resolved
Hide resolved
javascript/ql/lib/semmle/javascript/internal/flow_summaries/UrlSearchParams.qll
Dismissed
Show resolved
Hide resolved
adityasharad
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18757.
With the data flow migration, the old model of
URLSearchParamsstopped working because its pseudo-properties were not included inPropertyName.I've confirmed that simply including them in
PropertyNamewould fix the observed issue, but I went ahead and ported the model to flow summaries. I decided to model the object as aMapsince it shares most of the same interface and the addition ofgetAllis unlikely to cause problems for regularMapobjects.