Rust: support glob members in workspaces #18802
Conversation
There was a problem hiding this comment.
PR Overview
This pull request adds support for glob members in Rust workspaces. The changes include new integration test files, updates to Cargo.toml files for workspace configuration, and modifications in the Rust analyzer extractor to incorporate glob matching for workspace members and exclusion logic.
- Added a simple executable and library to test workspace globs.
- Updated Cargo.toml files to define workspace members with glob patterns and exclusions.
- Modified rust_analyzer.rs to add a new helper function for glob pattern matching and updated workspace detection accordingly.
- Provided a basic Python integration test for workspace functionality.
Changes
| File | Description |
|---|---|
| rust/ql/integration-tests/workspace-with-glob/exe/src/main.rs | Added main file invoking the library function. |
| rust/ql/integration-tests/workspace-with-glob/exe/Cargo.toml | Configured executable package with dependency on lib. |
| rust/ql/integration-tests/workspace-with-glob/lib/Cargo.toml | Configured library package. |
| rust/ql/integration-tests/workspace-with-glob/other/Cargo.toml | Configured an additional package to be excluded from the workspace. |
| rust/ql/integration-tests/workspace-with-glob/Cargo.toml | Set up the workspace using glob members and exclude directives. |
| rust/ql/integration-tests/workspace-with-glob/test_workspace.py | Added integration test to verify workspace processing. |
| rust/ql/integration-tests/workspace-with-glob/lib/src/lib.rs | Provided the library function used by the executable. |
| rust/extractor/src/rust_analyzer.rs | Introduced functionality for matching workspace members with glob patterns and updated workspace detection accordingly. |
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
|
DCA looks good, with some projects benefiting particularly from this. We get one more missing call target for rust, but I would accept that. |
There was a problem hiding this comment.
This looks good to me, but have you checked that this works as expected on Windows? I believe * characters are not allowed in paths, and it might be that the Path type performs some OS specific checks.
We may also want to ensure a Pattern is only "compiled" once instead of creating patterns inside a loop.
No description provided.