Skip to content

Fix table alignment in supported languages article #18809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 20, 2025

Conversation

saritai
Copy link
Contributor

@saritai saritai commented Feb 18, 2025

The alignment of the tables in the "Supported languages and frameworks" article (except the first table) has recently changed to the center which doesn't look right. This most likely happened due to a change in the Sphinx version used to generate the site.

I've used the align property to make sure the tables align to the left. That seems to be the most straightforward way but let me know if there are any problems with that.

Note: There is also a weird thing going on with the footnotes being indented...not sure how to fix that

@Copilot Copilot AI review requested due to automatic review settings February 18, 2025 15:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@smowton
Copy link
Contributor

smowton commented Feb 18, 2025

Re the footnotes:

The blobs containing the footnote number and backlink have a taller line-height than the paragraph and are floating elements, so they bump the next line rightwards. Turning the line-height down from 18px to 17px fixes it, though it doesn't look fantastic.

@saritai saritai added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Feb 18, 2025
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left alignment will probably look better 👍🏻

@saritai
Copy link
Contributor Author

saritai commented Feb 20, 2025

Looks like we already have an issue for the footnote formatting: https://github.com/github/codeql-team/issues/4167. That will require more time to figure out, so I am going to go ahead and merge this as-is and leave fixing that other issue for another time.

@saritai saritai merged commit 26da997 into main Feb 20, 2025
6 checks passed
@saritai saritai deleted the saritai/docs-formatting-fix branch February 20, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants