Rust: More path resolution improvements #18823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
hvitved
force-pushed
the
rust/path-resolution-more
branch
from
b6c3a1b to
496f485
Compare
paldepind
reviewed
Feb 24, 2025
|
|
||
| /** Holds if this `impl` block declares an associated item named `name`. */ | ||
| pragma[nomagic] | ||
| predicate declares(string name) { |
There was a problem hiding this comment.
I think a name like hasAssocItem would be more immediately understandable.
paldepind
reviewed
Feb 24, 2025
Comment on lines
159
to
163
| this = | ||
| any(TypeParamItemNode param | | ||
| result = param.resolveABound().getASuccessorRec(name) and | ||
| result instanceof AssocItemNode | ||
| ) |
There was a problem hiding this comment.
Suggested change
| this = | |
| any(TypeParamItemNode param | | |
| result = param.resolveABound().getASuccessorRec(name) and | |
| result instanceof AssocItemNode | |
| ) | |
| result = this.(TypeParamItemNode).resolveABound().getASuccessorRec(name).(AssocItemNode) |
There was a problem hiding this comment.
Do we need to worry about lifetime bounds on type parameters? Filter them out?
There was a problem hiding this comment.
Lifetime type parameters are not part of ItemNode, so I don't think any filtering is needed.
paldepind
requested changes
Feb 24, 2025
Comment on lines
159
to
163
| this = | ||
| any(TypeParamItemNode param | | ||
| result = param.resolveABound().getASuccessorRec(name) and | ||
| result instanceof AssocItemNode | ||
| ) |
There was a problem hiding this comment.
Do we need to worry about lifetime bounds on type parameters? Filter them out?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for resolving trait items with default implementations, and items defined in type parameter bounds.