JavaScript: Add new query UnusedIndexVariable.
#1910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. I have nothing to add. Interestingly, the rdf-store alert is in code from a parser generator (https://github.com/pegjs/pegjs). |
ghost
previously approved these changes
Sep 11, 2019
|
Ping @Semmle/doc for query help review. |
shati-patel
reviewed
Sep 11, 2019
| <p> | ||
| If the loop variable of a <code>for</code> loop ranges over the indices of an array, that variable | ||
| would normally be used as an array index in the body of the loop. If, instead, the loop body only | ||
| refers to array elements at constant indices, this may indicate a logic error or left-over testing |
There was a problem hiding this comment.
Suggested change
| refers to array elements at constant indices, this may indicate a logic error or left-over testing | |
| refers to array elements at constant indices, this may indicate a logic error or leftover testing |
xiemaisi
force-pushed
the
js/unused-index-variable
branch
from
b9e56c6 to
500cde6
Compare
shati-patel
approved these changes
Sep 11, 2019
ghost
approved these changes
Sep 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A cheap and cheerful query inspired by this PVS Studio check. It flags loops of the form
where all index operations on
ainside the loop body use a constant indexcand not the loop variablei.Dist-compare shows a bunch of true positives. The alerts on ChakraCore are false positives (the tests do this on purpose), but they are filtered away by default anyway.
Testing on LGTM.com, I also found this plausible-looking result in the source code for the Angular.js homepage. (There are a few copies of the same code in some other projects.)