Skip to content

Rust: accept test changes for now #19110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged

Rust: accept test changes for now #19110

merged 1 commit into from
Mar 25, 2025

Conversation

redsun82
Copy link
Contributor

No description provided.

@Copilot Copilot AI review requested due to automatic review settings March 25, 2025 11:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • rust/ql/test/query-tests/security/CWE-312/CleartextLogging.expected: Language not supported

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@github-actions github-actions bot added the Rust Pull requests that update Rust code label Mar 25, 2025
Copy link
Contributor

@geoffw0 geoffw0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super happy with this, not the test so much as the fact we haven't yet diagnosed why we're seeing different results on different machines. But the tests passing on CI is clearly better than the tests failing on CI.

@redsun82 redsun82 merged commit 9dc9f79 into rc/3.17 Mar 25, 2025
10 checks passed
@redsun82 redsun82 deleted the redsun82/rust-fix-rc.17 branch March 25, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants