Skip to content

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Mar 28, 2025

This should get rewritten to exclude the buildless repository.

…spec

This should get rewritten to exclude the buildless repository.
@Copilot Copilot AI review requested due to automatic review settings March 28, 2025 21:28
@smowton smowton requested a review from a team as a code owner March 28, 2025 21:28
@github-actions github-actions bot added the Java label Mar 28, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new buildless-maven variant for Java integration tests with the aim of excluding the buildless repository.

  • Added a Python test script to set up the environment.
  • Introduced a new Java unit test (AppTest.java) and main application logic (App.java) to verify Maven version and command line execution.

Reviewed Changes

Copilot reviewed 3 out of 13 changed files in this pull request and generated no comments.

File Description
java/ql/integration-tests/java/buildless-maven-mirrorof/test.py New Python test establishing an isolated environment with custom settings
java/ql/integration-tests/java/buildless-maven-mirrorof/src/test/java/com/example/AppTest.java New Java unit test to verify basic functionality
java/ql/integration-tests/java/buildless-maven-mirrorof/src/main/java/com/example/App.java Main application logic to check Maven version and command line parameters
Files not reviewed (10)
  • java/ql/integration-tests/java/buildless-maven-mirrorof/buildless-fetches.expected: Language not supported
  • java/ql/integration-tests/java/buildless-maven-mirrorof/diagnostics.expected: Language not supported
  • java/ql/integration-tests/java/buildless-maven-mirrorof/maven-fetches.expected: Language not supported
  • java/ql/integration-tests/java/buildless-maven-mirrorof/pom.xml: Language not supported
  • java/ql/integration-tests/java/buildless-maven-mirrorof/settings-xml.expected: Language not supported
  • java/ql/integration-tests/java/buildless-maven-mirrorof/settings.xml: Language not supported
  • java/ql/integration-tests/java/buildless-maven-mirrorof/source_archive.expected: Language not supported
  • java/ql/integration-tests/java/buildless-maven-mirrorof/src/main/resources/my-app.properties: Language not supported
  • java/ql/integration-tests/java/buildless-maven-mirrorof/src/main/resources/page.xml: Language not supported
  • java/ql/integration-tests/java/buildless-maven-mirrorof/src/main/resources/struts.xml: Language not supported
Comments suppressed due to low confidence (2)

java/ql/integration-tests/java/buildless-maven-mirrorof/test.py:2

  • The explicit import of 'os.path' is unnecessary since it's available via the 'os' module. Consider removing this redundant import.
import os.path

java/ql/integration-tests/java/buildless-maven-mirrorof/src/main/java/com/example/App.java:20

  • Consider adjusting the formatting of this error message to clearly separate the 'mavenHome' path from the rest of the text (e.g., by adding appropriate spaces or punctuation).
System.err.println("Wrong maven version, expected '" + expectedVersion + "' but got '" + observedVersion + "'" + mavenHome);

Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more

@smowton smowton merged commit 31ccd65 into github:main Mar 31, 2025
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants