actions: add MaD model for permissions needed by actions #19166
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this to suggest minimal set of nedded permissions
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a new MaD model to specify the minimal permissions required for actions, supporting the permission lookup for CodeQL queries.
- Added a new test workflow (perms6.yml) for a CWE-275 scenario.
- Created a configuration file (actions_permissions.yml) listing required permissions for various actions along with TODO comments for pending additions.
Reviewed Changes
Copilot reviewed 2 out of 8 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| actions/ql/test/query-tests/Security/CWE-275/.github/workflows/perms6.yml | Introduces a new workflow to test permission configuration. |
| actions/ql/lib/ext/config/actions_permissions.yml | Defines a new data model for action permissions with minimal required scopes. |
Files not reviewed (6)
- actions/ql/lib/codeql/actions/Ast.qll: Language not supported
- actions/ql/lib/codeql/actions/ast/internal/Ast.qll: Language not supported
- actions/ql/lib/codeql/actions/config/Config.qll: Language not supported
- actions/ql/lib/codeql/actions/config/ConfigExtensions.qll: Language not supported
- actions/ql/src/Security/CWE-275/MissingActionsPermissions.ql: Language not supported
- actions/ql/test/query-tests/Security/CWE-275/MissingActionsPermissions.expected: Language not supported
Tip: Copilot code review supports C#, Go, Java, JavaScript, Markdown, Python, Ruby and TypeScript, with more languages coming soon. Learn more
yoff
changed the title
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
adityasharad
previously approved these changes
Apr 1, 2025
|
Ah forgot to mention - change note in the query pack please. Something like "Alerts produced by the query |
Co-authored-by: Aditya Sharad <6874315+adityasharad@users.noreply.github.com>
adityasharad
approved these changes
Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use this to suggest minimal set of needed permissions.
For review: Do the permissions depend on the version of the actions? Currently, the version is stripped before the permissions are looked up.