Java: generalise javax.persistence models to also recognise jakarta.persistence.
#19187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Files not reviewed (3)
- java/ql/lib/semmle/code/java/deadcode/DeadField.qll: Language not supported
- java/ql/lib/semmle/code/java/deadcode/EntryPoints.qll: Language not supported
- java/ql/lib/semmle/code/java/frameworks/javaee/Persistence.qll: Language not supported
Tip: Copilot only keeps its highest confidence comments to reduce noise and keep you focused. Learn more
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jcogs33
previously approved these changes
Apr 1, 2025
Co-authored-by: Jami <57204504+jcogs33@users.noreply.github.com>
aschackmull
approved these changes
Apr 2, 2025
|
I hadn't; I'll do a DCA now to cross-check. I've made a special-purpose suite consisting of some repos that use javax.persistence and some that use jakarta.persistence, since none in the default DCA suite do, which could hide a problematic join behind a zero result in a sentinel predicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.