Skip to content

C#: Remove false positives from cs/dereferenced-value-may-be-null #1982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 20, 2019
Merged

C#: Remove false positives from cs/dereferenced-value-may-be-null #1982

merged 5 commits into from
Sep 20, 2019

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Sep 20, 2019

This PR removes false positives from cs/dereferenced-value-may-be-null by

  • teaching the comparison library about dynamic comparison operations, and
  • teaching the guards library about additional null checks.

The PR can be reviewed commit-by-commit.

@hvitved hvitved added the C# label Sep 20, 2019
@hvitved hvitved requested review from calumgrant and jf205 September 20, 2019 08:49
@hvitved hvitved requested a review from a team as a code owner September 20, 2019 08:49
calumgrant
calumgrant approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff!

jf205
jf205 approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@jf205 jf205 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change note LGTM

@calumgrant calumgrant merged commit b31cd8a into github:master Sep 20, 2019
@hvitved
Copy link
Contributor Author

hvitved commented Sep 22, 2019

Here is the dist-compare report (internal link).

@hvitved hvitved deleted the csharp/null-maybe-dynamic branch September 22, 2019 16:34
@hvitved hvitved mentioned this pull request Sep 22, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jf205 jf205 jf205 approved these changes

+1 more reviewer

@calumgrant calumgrant calumgrant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hvitved @calumgrant @jf205