Skip to content

Go: Update Go version to 1.25.0 #20210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 13, 2025
Merged

Go: Update Go version to 1.25.0 #20210

merged 5 commits into from
Aug 13, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Aug 12, 2025

The failure of Go Resolve Build Environment Tests looks expected. The test does pass on the internal PR (after workflow updates).

See the internal PR for a DCA experiment.

@github-actions github-actions bot added the Go label Aug 12, 2025
@jketema jketema changed the title Go: Update Go version to 1.25.0-rc.3 Go: Update Go version to 1.25.0 Aug 13, 2025
@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Aug 13, 2025
@jketema jketema marked this pull request as ready for review August 13, 2025 13:22
@jketema jketema requested review from a team as code owners August 13, 2025 13:22
@jketema jketema requested review from Copilot and removed request for a team August 13, 2025 13:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Go version from 1.24.0 to 1.25.0 across the codebase to modernize the toolchain and support newer Go features and improvements.

  • Updates Go module requirements and toolchain version
  • Adjusts build environment compatibility settings
  • Updates test action default Go version and Bazel rules

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
go/extractor/go.mod Updates Go version requirement and toolchain from 1.24 to 1.25
go/extractor/autobuilder/build-environment.go Updates maximum supported Go version to 1.25
go/actions/test/action.yml Updates default Go test version to 1.25.0
MODULE.bazel Updates Bazel rules_go version and Go SDK download version

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! :shipit: I see that rules_go now works out-of-the-box and the workaround is no longer needed, which is great too.

@jketema jketema merged commit ff288d7 into main Aug 13, 2025
34 of 37 checks passed
@jketema jketema deleted the jketema/go-1.25 branch August 13, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
depends on internal PR This PR should only be merged in sync with an internal Semmle PR Go
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants