-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Go: Update Go version to 1.25.0 #20210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
a460dce
to
3ff3515
Compare
1.25.0-rc.3
3ff3515
to
9a6303e
Compare
This version includes bazel-contrib/rules_go#4397 which addresses the build fialure we were seeing.
9a6303e
to
5e2a560
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Go version from 1.24.0 to 1.25.0 across the codebase to modernize the toolchain and support newer Go features and improvements.
- Updates Go module requirements and toolchain version
- Adjusts build environment compatibility settings
- Updates test action default Go version and Bazel rules
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
File | Description |
---|---|
go/extractor/go.mod | Updates Go version requirement and toolchain from 1.24 to 1.25 |
go/extractor/autobuilder/build-environment.go | Updates maximum supported Go version to 1.25 |
go/actions/test/action.yml | Updates default Go test version to 1.25.0 |
MODULE.bazel | Updates Bazel rules_go version and Go SDK download version |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I see that
rules_go
now works out-of-the-box and the workaround is no longer needed, which is great too.
The failure of Go Resolve Build Environment Tests looks expected. The test does pass on the internal PR (after workflow updates).
See the internal PR for a DCA experiment.