Rust: Model async return types as dyn Future
#20236
Draft
+75
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // Type mentions required by type inference | ||
|
|
||
| use std::future::Future; | ||
| fn mention_dyn_future<T>(f: &dyn Future<Output = T>) {} |
Check notice
Code scanning / CodeQL
Unused variable Note
| use std::future::Future; | ||
| fn mention_dyn_future<T>(f: &dyn Future<Output = T>) {} | ||
|
|
||
| fn mention_dyn_fn_once<F>(f: &dyn FnOnce() -> F) {} |
Check notice
Code scanning / CodeQL
Unused variable Note
hvitved
force-pushed
the
rust/type-inference-async-dyn-future
branch
from
37b1b73 to
f847160
Compare
hvitved
force-pushed
the
rust/type-inference-async-dyn-future
branch
from
f847160 to
f7f08f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of assigning the type
Futuredirectly, we assigndyn Future, just like we assigndyn FnOnceto closures. As @paldepind notes on that PR, usingimpl Futurewould be more faithful, but in terms of our type inference implementation the effect is the same.