Rust: Rework call resolution and type inference for calls #20282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
2 times, most recently
from
e4cfb86 to
4a8c37c
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
4a8c37c to
e75d79e
Compare
| * argument of `potentialInstantiationOf`. | ||
| */ | ||
| default predicate relevantTypeMention(TypeMention tm) { potentialInstantiationOf(_, _, tm) } | ||
| default predicate relevantTypeMention(Constraint tm) { potentialInstantiationOf(_, _, tm) } |
Check warning
Code scanning / CodeQL
Missing QLDoc for parameter Warning
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
8 times, most recently
from
61866bf to
2d1ed65
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
2d1ed65 to
3d19a06
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
3d19a06 to
153c10b
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
153c10b to
e161d4c
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
dd45f7b to
a20c440
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
5 times, most recently
from
f45d2d5 to
f9f8782
Compare
| pragma[nomagic] | ||
| private Type inferMethodCallExprType(AstNode n, TypePath path) { | ||
| exists( | ||
| MethodCallMatchingInput::Access a, MethodCallMatchingInput::AccessPosition apos, string env, |
Check warning
Code scanning / CodeQL
Omittable 'exists' variable Warning
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
3 times, most recently
from
1207021 to
85c5935
Compare
hvitved
changed the title
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
10 times, most recently
from
63cf1bb to
9c7019a
Compare
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
5 times, most recently
from
0db4536 to
b1d79d2
Compare
```
Evaluated relational algebra for predicate _PathResolution::CrateItemNode.getName/0#dispred#91b4dd6b_PathResolution::SourceFileItemNode#bd8f490__#antijoin_rhs@e84aee8k with tuple counts:
35406180 ~0% {3} r1 = JOIN PathResolution::SourceFileItemNode#bd8f4905 WITH `PathResolution::CrateItemNode.getName/0#dispred#91b4dd6b` CARTESIAN PRODUCT OUTPUT Lhs.0, Rhs.1, Rhs.0
8455 ~2% {4} | JOIN WITH `PathResolution::declaresDirectly/3#7d0350fb_021#join_rhs` ON FIRST 2 OUTPUT Rhs.2, Lhs.0, Lhs.2, Lhs.1
3259 ~0% {3} | JOIN WITH num#PathResolution::TTypeNamespace#4897e416 ON FIRST 1 OUTPUT Lhs.1, Lhs.2, Lhs.3
return r1
```
hvitved
force-pushed
the
rust/type-inference-method-call-resolution-rework
branch
from
b1d79d2 to
bb53427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.