JS: Detect property injection via object enumeration patterns #20296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the JavaScript remote property injection query to detect vulnerabilities through object enumeration patterns like Object.keys(). The enhancement catches cases where user-controlled data flows through object enumeration methods before being used as property names.
- Adds additional flow step to track property names derived from object enumeration
- Updates test cases to include Object.keys() enumeration patterns
- Creates change notes documenting the analysis improvement
Reviewed Changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| RemotePropertyInjectionQuery.qll | Adds flow step to track enumerated property names from source objects |
| tst.js | Adds test case demonstrating Object.keys() vulnerability pattern |
| RemotePropertyInjection.expected | Updates expected query results with new test case findings |
| 2025-08-27-remote-property-injection-update.md | Documents the query enhancement in change notes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the
js/remote-property-injectionquery to catch vulnerabilities where user-controlled data flows through object enumeration methods like Object.keys().