Skip to content

C++: Add class representing PCH files #20298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Aug 28, 2025
Merged

C++: Add class representing PCH files #20298

merged 7 commits into from
Aug 28, 2025

Conversation

jketema
Copy link
Contributor

@jketema jketema commented Aug 27, 2025 •
edited
Loading

See internal PR for details.

@jketema jketema added the depends on internal PR This PR should only be merged in sync with an internal Semmle PR label Aug 27, 2025
@jketema jketema changed the title C++: Add class represention PCH files C++: Add class representing PCH files Aug 27, 2025
@jketema jketema marked this pull request as ready for review August 27, 2025 16:14
@jketema jketema requested a review from a team as a code owner August 27, 2025 16:15
@Copilot Copilot AI review requested due to automatic review settings August 27, 2025 16:15
Copilot
Copilot AI reviewed Aug 27, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

IdrissRio
IdrissRio previously approved these changes Aug 28, 2025
View reviewed changes
Copy link
Contributor

@IdrissRio IdrissRio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment otherwise LGTM 👍

@jketema @IdrissRio
Update cpp/ql/lib/semmle/code/cpp/PchFile.qll
3112664 
Co-authored-by: Idriss Riouak <idrissrio@github.com>
@jketema
Copy link
Contributor Author

jketema commented Aug 28, 2025

@IdrissRio Could you re-approve this PR?

@jketema jketema merged commit 1847a45 into github:main Aug 28, 2025
17 checks passed
@jketema jketema deleted the pch-expose branch August 28, 2025 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@IdrissRio IdrissRio IdrissRio approved these changes

Assignees
No one assigned
Labels
C++ depends on internal PR This PR should only be merged in sync with an internal Semmle PR documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jketema @IdrissRio