Rust: Tune rust/diagnostic/database-quality #20312
Merged
+6
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR tunes the Rust database quality diagnostic query to reduce false positives by changing the threshold for triggering quality warnings from 95% to 50% for both call target and macro call target statistics.
- Adjusts the percentage threshold from 95% to 50% for quality warnings
- Consolidates the logic by moving the percentage check inline with each statistics report check
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| DatabaseQualityDiagnostics.ql | Updates threshold logic to reduce false positive quality warnings |
| 2025-08-28-diagnostic-database-quality.md | Adds change note documenting the fix for spurious quality warnings |
hvitved
approved these changes
Aug 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tune
rust/diagnostic/database-qualityto reflect the range of values typically seen in the metrics it measures. This will greatly reduce the proportion of databases the warning triggers on, avoiding unnecessary alarm.