-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Add additional SystemWeb HttpRequset properties to C# test stubs #20513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional SystemWeb HttpRequset properties to C# test stubs #20513
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uh, thank you for doing this! 😄
Stub should not include code logic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
It looks like the change to the stubs doesn't compile with all the tests. |
@michaelnebel I don't have access to see which tests exactly in the "C# Language Tests Linux" pipeline is failing, I have started trying to kick them all off manually locally on my machine but I expect this process to take quite a while. I have found the "TaintedPath.qlref" test is failing which seems to be related to the .expected steps changing from this PR, but if you could provide me a full list so I can verify that would save me some time and hassle. Thank you! |
Oh, that makes it a lot harder to debug. Thank you for your persistence! |
@michaelnebel Thank you for the commit, I cherry picked it and have added it to the PR. Fingers crossed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add additional HttpRequest properties to the System.Web.cs test stubs.