C++: support __builtin_complex
#2115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickrolfe
added
C++
depends on internal PR
|
This was a little premature - I still need to generate stats and an upgrade script. |
|
LGTM. I assume it's best we wait for stats before merging this. |
nickrolfe
force-pushed
the
builtin_complex
branch
from
48166ff to
22fa657
Compare
|
The test is failing. Is this just a matter of merging at the same time as https://git.semmle.com/Semmle/code/pull/34689? |
|
Yes, the test in this PR is failing because it's running against a |
|
LGTM. But I can't approve the PR. |
matt-gretton-dann
approved these changes
Oct 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.