Skip to content

CPP: BitwiseSignCheck.ql fix #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 14, 2019
Merged

CPP: BitwiseSignCheck.ql fix #2122

merged 3 commits into from
Oct 14, 2019

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Oct 14, 2019

See discussion in #2120.

I've also added a test case for a separate issue, that we don't catch e >= 1 (which is equivalent to e > 0).

@geoffw0 geoffw0 added the C++ label Oct 14, 2019
@geoffw0 geoffw0 requested a review from a team as a code owner October 14, 2019 11:02
@geoffw0 geoffw0 mentioned this pull request Oct 14, 2019
Closed
jbj
jbj approved these changes Oct 14, 2019
View reviewed changes
Copy link
Contributor

@jbj jbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with your reasoning. LGTM!

@jbj jbj merged commit 527ec4a into github:master Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbj jbj jbj approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffw0 @jbj