Skip to content

Allow "badly bounded" writes to a size 0 buffer #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Allow "badly bounded" writes to a size 0 buffer #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcfcb04
If a destination buffer has size 0, there's probably some hackery goi…
sauyon Sep 13, 2018
de7a355
Documentation wording
sauyon Oct 8, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cpp/ql/src/Security/CWE/CWE-120/BadlyBoundedWrite.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,5 @@ from BufferWrite bw, int destSize
where bw.hasExplicitLimit() // has an explicit size limit
and destSize = getBufferSize(bw.getDest(), _)
and (bw.getExplicitLimit() > destSize) // but it's larger than the destination
and not destSize = 0 // probably a variable-size member if the destination size is 0
select bw, "This '" + bw.getBWDesc() + "' operation is limited to " + bw.getExplicitLimit() + " bytes but the destination is only " + destSize + " bytes."