JavaScript: Fix a bug in ServerSideUrlRedirect #259
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The server-side redirect query did not handle sinks in this case:
because the logic in
Sink.maybeNonLocal()
required that a prefix of the sink must be anExpr
. In this case, the prefix is found to be aParameterNode
whoseasExpr()
has no result.I've refactored
getAPrefix
to return aDataFlow::Node
and only coerce toExpr
when doinggetStringValue()
.