JavaScript: Introduce new query UnclearOperatorPrecedence.
#260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
added 2 commits
October 2, 2018 08:46
xiemaisi
force-pushed
the
js/confusing-precedence
branch
from
8b05e26 to
7683684
Compare
ghost
approved these changes
Oct 2, 2018
mchammer01
approved these changes
Oct 3, 2018
smowton
added a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
…-substitution-done Note type substitution TODO done
MathiasVP
pushed a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
…alization Powershell Unsafe Deserialize query
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using bitwise operators, it's easy to write code like
x & 4 !== 0without realising that this is interpreted asx & (4 !== 0)and not(x & 4) !== 0. My favourite example of this comes from an old version of Angular.js, but other examples abound.The second commit adds a query for flagging such nestings between bitwise operators and relational operators, which reuses some logic from the whitespace-contradicts-precedence query pulled out in the first commit. I improved that query to take advantage of per-token location while I was at it.
Performance looks fine (it's of course an entirely syntactic query), and there are many decent results. I've made it a recommendation since smart people use this sort of idiom on purpose.