Merge master into next. #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For ease of reviewing, I've checked in the .expected files from the AST-based guards library. The next commit accepts output for these tests and adds tests that use getAST rather than the translation layer.
We have external users editing queries with Visual Studio, and it seems to automatically add very specific files to `.gitignore`. These changes cause conflicts between unrelated PRs. This commit adds all of `/.vs` to `.gitignore`, which should hopfully make Visual Studio stop adding more entries.
Approved by xiemaisi
Approved by xiemaisi
Approved by hvitved, xiemaisi, yh-semmle
.gitignore everything under .vs in repo root dir
The IR for the conversion to bool results in a comparison where the left hand side is not the result of any expression in the AST, so they can't be usefully converted back to the AST
This is motivated by test performance; IR compilation happens separately for each test and takes a bit over a minute, so combining these 8 tests saves about 10 minutes of test running.
…1.18 Version: Fix C# and JavaScript Eclipse plugins for 1.18.
IR-based guards library
Approved by yh-semmle
Previously, `Instruction.toString()` returned the same string that is used in IR dumps, which requires numbering all instructions and generating a unique string for each instruction. This is too expensive on large snapshots. I've moved the original code into the new `Instruction.getDumpString()`, and made `Instruction.toString()` just return the opcode plus `getAST().toString()`.
…String C++: Make `Instruction.toString()` less expensive
Version: Bump to 1.18.1 dev.
JavaScript: Update model of `DOMException`.
Merge rc/1.18 into master.
adityasharad
added
depends on internal PR
Closed
aibaars
approved these changes
Oct 1, 2018
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
Powershell SMB settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should be merged after the corresponding internal PR. Test results should be checked on the internal PR instead of this one.