JS: model path-is-inside+is-path-inside for js/path-injection
#2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
var inside = require("path-is-inside")
inside("foo/bar/../../../../../etc/passwd", "foo/bar") === trueThe |
asgerf
reviewed
Jan 30, 2020
| outcome = true | ||
| // Note that `is-path-inside` states: | ||
| // > "Note that relative paths are resolved against process.cwd() to make them absolute." | ||
| // so it may be possible to undo this sanitization by later prepending some other path to the sanitized path. |
There was a problem hiding this comment.
Did you mean to leave this comment here? Doesn't seem like something we need to worry about.
esbena
added
the
Awaiting evaluation
asgerf
reviewed
Feb 3, 2020
|
|
||
| IsInsideCheckSanitizer() { | ||
| exists(string name, DataFlow::CallNode check | | ||
| name = "path-is-inside" or |
There was a problem hiding this comment.
In line with @erik-krogh's comment, could you make path-is-inside only sanitize normalized absolute paths?
There was a problem hiding this comment.
I am waiting to see if Erik's PR against path-is-inside gets accepted.
There was a problem hiding this comment.
That PR seems to have entered the void. path-is-inside is now a weaker sanitizer.
esbena
force-pushed
the
js/support-path-is-inside
branch
from
9d4b0df to
63a0d6b
Compare
esbena
force-pushed
the
js/support-path-is-inside
branch
from
63a0d6b to
0061c0e
Compare
esbena
force-pushed
the
js/support-path-is-inside
branch
from
0061c0e to
5baba62
Compare
|
I forgot about |
esbena
removed
the
Awaiting evaluation
asgerf
approved these changes
Feb 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following pattern sanitizes paths wrt. path injection.
This PR models two confusingly similar packages: 'path-is-inside' and 'is-'path-inside' for that purpose.
Evaluation is pending.