JS: Improve flow through receiver of partial invokes #2796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were missing flow from
context
tothis
in this case, needed for flagging a CVE:There's a bunch of other cases where this happened, previously modelled in the type inference using a couple of
AnalyzedThisXXX
classes.I've tweaked
PartialInvokeNode
a bit so this can be modelled as a partial invocation, and changed theAnalyzedThisInXXX
classes to instead be partial invokes, and their contribution to type inference generalized to work for any partial invoke.So far I've evaluated the last commit against the first one, to confirm that nothing had happens from the refactoring of the
AnalyzedThis
classes (and that it doesn't blow up), but it still needs a comparison against master to see what the constant-factor overhead is.