Python: ObjectAPI to ValueAPI: ExpectedMappingForFormatString #2827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BekaValentine
changed the title
tausbn
requested changes
Feb 18, 2020
tausbn
requested changes
Feb 24, 2020
tausbn
previously approved these changes
Mar 3, 2020
RasmusWL
requested changes
Mar 5, 2020
There was a problem hiding this comment.
Sorry to disrupt this PR, but I think we need to agree on how we want to handle referencing things by name.
I've seen this use of someClass.getName() = "FooBar" in multiple places. Should we be using someClass = Value::named("FooBar") instead? I've been doing that on my own, but I think we need a clear guideline on that in general for Python 🐍 @Semmle/python
I've made a suggestion for an instance I found in this PR, but please wait with accepting it before we have consensus 😛
Co-Authored-By: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
RasmusWL
requested changes
Mar 10, 2020
…f github.com:BekaValentine/ql into objectapi-to-valueapi-expectedmappingforformatstring
RasmusWL
approved these changes
Mar 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the effort to modernize the Expressions queries, moving away from the use of
refersToand associated APIs, and towardspointsToand its associated APIs.