docs: continue reorganizing 'Advanced QL' #2829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shati-patel
approved these changes
Feb 13, 2020
|
|
||
| The result of this query is a list of the most specific types of every ``Expr`` in that function. You will see multiple results for expressions that are represented by more than one type, so it will likely return a very large table of results. | ||
|
|
||
| Use ``getAQlClass()`` as a debugging tool, but don't include it in the final version of your query, as it slows down performance. |
There was a problem hiding this comment.
Maybe this would be more visible as a note/warning?
|
@max-schaefer over to you for a technical review, if you have a moment please |
|
Since these are fairly uncontroversial changes, I'd like to get this merged now as it's blocking https://github.com/github/product-documentation/issues/2157 @max-schaefer if you do have time to review, feel free to add comments here and I'll address them in a follow-up PR. @shati-patel, before we merge I'll retarget this against rc/1.23 so that the changes become visible when we update help.semmle.com from that branch. |
|
Actually, I'm going to open a fresh PR. Retargetting introduces many conflicts. Closing this now. |
|
Replaced by #2876. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially fixes https://github.com/github/product-documentation/issues/2188.
This PR continues the work started in #2583. I'm trying to reorganize the Advanced QL section. Hopefully we'll be able to get rid of that section altogether soon.
Changes in this PR
TODO