Skip to content

C#: Teach null-guards library about pattern matching #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2018
Merged

C#: Teach null-guards library about pattern matching #284

merged 1 commit into from
Oct 17, 2018

Conversation

hvitved
Copy link
Contributor

@hvitved hvitved commented Oct 5, 2018

The library now recognizes null-guards such as

if (x is string)
    return x.ToString(); // x is not null

and

switch (x)
{
    case null:
        return "";
    default:
        return x.ToString(); // x is not null
}

@hvitved hvitved added the C# label Oct 5, 2018
@hvitved hvitved requested a review from calumgrant October 5, 2018 11:43
@hvitved hvitved requested a review from a team as a code owner October 5, 2018 11:43
@hvitved hvitved force-pushed the csharp/null-guards branch 2 times, most recently from 02e25e8 to 42e0fa3 Compare October 8, 2018 13:10
@hvitved hvitved force-pushed the csharp/null-guards branch from 42e0fa3 to 603c3d6 Compare October 15, 2018 08:56
@hvitved
Copy link
Contributor Author

hvitved commented Oct 16, 2018

Ping @calumgrant

calumgrant
calumgrant approved these changes Oct 17, 2018
View reviewed changes
Copy link
Contributor

@calumgrant calumgrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice.

@calumgrant calumgrant merged commit 0ddb702 into github:master Oct 17, 2018
@hvitved hvitved deleted the csharp/null-guards branch October 17, 2018 18:32
@hvitved hvitved mentioned this pull request Oct 24, 2018
Merged
aibaars pushed a commit that referenced this pull request Oct 14, 2021
@hvitved
Merge pull request #284 from github/hvitved/instanceof-test
8ce7fdc 
Use `instanceof` base classes
smowton pushed a commit to smowton/codeql that referenced this pull request Apr 16, 2022
@igfoo
Merge pull request github#284 from github/igfoo/logfile
4eda698 
Kotlin: Log to a file, not stdout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@calumgrant calumgrant calumgrant approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
C#
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hvitved @calumgrant