Skip to content

JS: Do not flag void operands MissingAwait #2868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2020
Merged

JS: Do not flag void operands MissingAwait #2868

merged 1 commit into from
Feb 20, 2020

Conversation

asgerf
Copy link
Contributor

@asgerf asgerf commented Feb 19, 2020

Fixes the FP in #2865

@asgerf asgerf added the JS label Feb 19, 2020
@asgerf asgerf requested a review from a team as a code owner February 19, 2020 09:30
max-schaefer
max-schaefer approved these changes Feb 19, 2020
View reviewed changes
Copy link
Contributor

@max-schaefer max-schaefer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could perhaps do with a change note, unless this query is new in 1.24 (can't remember off the top of my head).

@semmle-qlci semmle-qlci merged commit 8b277f7 into github:master Feb 20, 2020
@AlCalzone AlCalzone mentioned this pull request Mar 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@max-schaefer max-schaefer max-schaefer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
JS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@asgerf @max-schaefer @semmle-qlci