CPP: Address Widechartype / WChar_t #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aibaars
pushed a commit
that referenced
this pull request
Oct 14, 2021
Make barrier guards more specific
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
Change array.get calls to array indexing in FunctionN.invoke body
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few weeks ago that we have two very similar QL classes, 'WideCharType' and 'Wchar_t'. This PR adds comments to clarify the difference, hinting that 'Wchar_t' is normally the right one to use. I've also corrected some uses of 'WideCharType' where I believe it to be the wrong choice.
Investigative query at https://lgtm.com/query/1506594176863/.